bring back `DROP_CLIENT_UNKNOWN` as opt out?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 568
- Forks
- 447
- PR merge metrics
- No merged PRs in 30d
Description
Updated Electrum to recent version, and discovered that after https://github.com/spesmilo/electrumx/pull/325 electrum rejects all the clients that dont start with version negotiaton first.
It used to be an opt-it via DROP_CLIENT_UNKNOWN env, but now its forced with no way to opt-out.
I quickly patched the production instance (basically unmerged #325), but would you be open to accept PR that reintroduces same configuration, but in 'opt out' fashion?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #325 and the existing handling of the DROP_CLIENT_UNKNOWN environment setting. Trace how clients without version negotiation are currently rejected and identify the related tests or configuration documentation. Done means the rejection behavior can be controlled using the requested opt-out configuration, with coverage for both settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100