spesmilo / spesmilo/electrum

AttributeError: 'NoneType' object has no attribute 'need_finalize'

Open
#8,908 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Crash Report

This crash report was reported through the automatic crash reporting system 🤖

Traceback

Traceback (most recent call last):
  File "electrum/gui/qt/send_tab.py", line 562, in do_pay_or_get_invoice
AttributeError: 'NoneType' object has no attribute 'need_finalize'

AttributeError: 'NoneType' object has no attribute 'need_finalize'

Reporter

This issue was reported by 4 user(s):

Electrum Version Python Version Operating System Wallet Type Locale Stack
4.5.2 3.10.11 (v3.10.11:7d4cc5aa85, Apr 4 2023, 19:05:19) [Clang 13.0.0 (clang-1300.0.29.30)] macOS-14.2.1-x86_64-i386-64bit standard ?
4.5.5 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:20:04) [MSC v.1929 32 bit (Intel)] Windows-10-10.0.19045-SP0 imported,standard de_DE
4.5.5 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:20:04) [MSC v.1929 32 bit (Intel)] Windows-10-10.0.19045-SP0 imported,standard de_DE
4.5.8 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:20:04) [MSC v.1929 32 bit (Intel)] Windows-10-10.0.19045-SP0 2of2,standard sv_SE

Additional Information

The reporting user(s) did not provide additional information.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting electrum/gui/qt/send_tab.py around line 562 and the do_pay_or_get_invoice path. Reproduce the reported send or invoice flow if possible, then determine when the value is None; done means the crash is prevented and the affected flow is covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.