Request item is not correcly marked for progress (minor GUI bug, Qt)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
This is on Electrum 4.4.4, Linux. A small GUI bug, hopefully easy to fix, so I report as this may come "surprising" to a user first, thinking "Whhhatt???"
To reproduce:
- Have some very old payment request laying around
- Create a payment request, that will reuse the expired address
- Receive the payment
Current result:
- This is on the Requests tab, sorry for localized screenshot. The old, expired request's status will be updated with "Not confirmed":
Expected result:
- As the arrow points on my picture, the payment that is being received is for the topmost request, so that should indicate the status! Not the expired one.
(I wondered who paid that old test??? So this is not good.)
Note: on History tab the "Comment" of the correct item is copied.
Thank you!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on Electrum 4.4.4 on Linux using the Qt Requests tab: keep an expired payment request, create a request that reuses its address, and receive a payment. Compare which request receives the “Not confirmed” status with the correct item and the copied History comment; done means the receiving request is marked instead of the expired one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100