spesmilo / spesmilo/electrum

electrum/www/pay is not a symlink in the tarball

Open
#8,030 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build/packaging 📦
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

In the Git repository electrum/www/pay is a symlink to electrum/www/index.html. However, in the tarball, pay is a separate file with identical contents. When it is not a symlink, trying to access it with a browser causes a download to be initiated instead of displaying the website.

My guess is that some aspect of the packaging of the tarball is converting the symlink into a separate file, but I am unsure at what stage that is happening.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting how the release tarball is produced and compare electrum/www/pay with electrum/www/index.html in the repository and archive. Trace where the symlink becomes a regular file; done means the tarball preserves pay as a symlink so browsers display the website instead of downloading it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.