spesmilo / spesmilo/electrum

The password/encryption dialog when creating a new wallet is a bit confusing, and too relaxed about requiring a password.

Open
#7,362 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

The encrypt wallet checkbox is checked by detault (good) but is greyed out unless one fills in a password. This creates the impression that the wallet maybe is encrypted even without a password.

And what is worse is that it's by default accepted to leave the password field blank which leaves everything unencrypted, not even a warning. Just click next once and the wallet is completely unprotected.

Would suggest adding a "require password" checkbox, enabled by default. And should not be possible to create a password less wallet unless one unchecks it (which also greys out the password and "encrypt wallet"). And make the "encrypt wallet" checkbox availability dependent on the "require password" checkbox and not the password fields to better illustrate the password dependency for encryption.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the new-wallet password and encryption dialog and trace how its checkbox states affect wallet creation. Confirm how blank passwords are currently accepted, then make the require-password and encryption behavior match the issue; done means the dialog clearly distinguishes protected and unprotected wallets and prevents accidental unencrypted creation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.