spesmilo / spesmilo/electrum

unsigned transaction size differs on import to offline machine

Open
#7,290 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic-transactions 📑
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Generating a transaction on my online watch wallet I get a size of 2000-something, but when I transfer to my offline signing wallet I get a size of 3000-something pre-signing (a good couple hundred greater!)!. Same versions of electrum. I saved the tx from online machine by copying to clipboard and saving to a text file.

For investigative purposes I created a watch wallet on the offline machine, and strangely when I import the unsigned transaction to this watch wallet, the transaction size appears correctly!

The unsigned transaction involves an old non-segwit address sending multiple outputs to a segwit address.

Obviously the differential in transaction size means the fee rate is wrong, so this seems like a bug.

Any assistance would be appreciated re ensuring I'm signing the right transaction (the size differential has monkey-wrenched this).

Possibly related issue: https://github.com/spesmilo/electrum/issues/6671

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report names no files, tests, or entry points. Start by reviewing the unsigned-transaction import path and the related issue #6671, then compare size and fee-rate handling for old non-segwit inputs sending to segwit outputs. Done means the transaction size remains consistent between online and offline wallets before signing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
payments
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.