spesmilo / spesmilo/electrum

The Ledger plugin is currently broken for old Ledgers HW1 (can get account addresses, but Electrum hanging when signing a Tx)

Open
#7,022 25 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

hw-ledger
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

The Ledger plugin is currently broken for old Ledgers HW1 (the type of ledger hardware wallets that have no display). Electrum displays a "read error" pop-up when attempting to send (i.e. to sign a Tx). Electrum is capable of getting the account addresses and display the balances, so communication with the WD1 ledger is working, but not possible to sign the Tx and send BTC (using Electrum 4.0.9).

I could maybe try to find the problem myself. What would you recommend to debug an Electrum Plugin?

I.e. if I need to print things from within the ledger.py plugin, should I use the regular Python print() or is there a way to print in the Electrum console? (I'll be using Linux)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Ledger plugin's ledger.py and reproduce the signing failure on Linux with Electrum 4.0.9, using the Electrum console or Python output to inspect the read error. Done means an old Ledger HW1 can sign and send a transaction without the read-error pop-up.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.