Windows build script trusts Python.org binaries and non-freedom Visual Studio (msvc, mingw, exe, crt, msvcrt, microsoft, gcc)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
The Windows build scripts include this: https://github.com/spesmilo/electrum/blob/6cfe822caf61f78bdfbbcce61977407494655f5a/contrib/build-wine/prepare-wine.sh#L54-L55
This is downloading Python binaries from Python.org. Those binaries are probably not reproducible, and they are built with a non-freedom compiler (Visual Studio 2017 AFAIK). It would be better to use Python binaries for Windows that are reproducibly cross-compiled from GNU/Linux.
Would a PR be accepted that does this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with contrib/build-wine/prepare-wine.sh at lines 54-55 and inspect how it downloads Python.org binaries. Define the reproducible GNU/Linux cross-compilation approach and required Windows artifacts; done means the Windows build no longer depends on those binaries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- build-system, operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100