spesmilo / spesmilo/electrum

in wallet with many hardware cosigners, pairing order should be smarter (pairing error, keystore, sign_transaction, multisig)

Open
#6,541 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

hw-generic topic-wallet 👛
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

I'm doing a stress test 8 of 8 native multisig wallet with 8 different hardware devices.

Electrum 4.0.2 appimage on debian

One odd issue I've noticed when starting to sign a transaction is that it seems to roll through prompting to connect every device, but if I connect a device out of order (which is really hard to determine) then I get this error:
Screenshot from 2020-08-26 18-20-11

To be precise, in this setup there are 2 different coldcards and in order to sign with the "second" coldcard I have to click "no" on the first connection attempt and THEN plug in the "second" coldcard.

Screenshot from 2020-08-28 12-40-12

Maybe this is a big ask since I'm not sure how the logic works, but it seems like electrum should be smart enough to detect that the device is actually part of the key set.

I'll also note that I have not experienced this issue with Trezor or Bitbox but have with Ledger. It might just be that I've always plugged them in in the expected order.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the sign_transaction and keystore entry points, then reproduce the 8-of-8 native multisig stress test using multiple hardware devices. Trace the pairing error when devices are connected out of order, including the Coldcard and Ledger cases; done means a device in the wallet's key set can be recognized without requiring the expected connection order.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.