spesmilo / spesmilo/electrum

Set default expiration time for payment requests 'Never"

Open
#6,364 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic-invoice-payreq
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Why a fresh wallet will default payment requests expiration to some other value than "Never"?
After upgrading, I had to configure an existing wallet to "Never" on requests tab. I think this should be the default, having 10 mins or something like this will increase the gap of users too much if many requests get burned / don't end up paid.

If someone wants a limited lifetime for the validity of a payment request for sure they will set it, but the average users almost never need or want to have an expiring payment request, so I think we should default to "Never" here on both Android and desktop.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Locate the payment-request expiration defaults in both the Android and desktop implementations, then verify that a fresh wallet uses “Never” and that existing configurable expiration choices still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop, mobile, payments
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.