spesmilo / spesmilo/electrum

EmptyLabel: A DNS label is empty.

Open
#6,331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Crash Report

This crash report was reported through the automatic crash reporting system 🤖

Traceback

  File "electrum\gui\qt\network_dialog.py", line 408, in set_proxy
  File "electrum\network.py", line 358, in run_from_another_thread
  File "concurrent\futures\_base.py", line 435, in result
  File "concurrent\futures\_base.py", line 384, in __get_result
  File "electrum\util.py", line 1037, in wrapper
  File "electrum\network.py", line 609, in set_parameters
  File "electrum\network.py", line 1126, in _start
  File "electrum\network.py", line 577, in _set_proxy
  File "electrum\dns_hacks.py", line 35, in configure_dns_depending_on_proxy
  File "electrum\dns_hacks.py", line 43, in _prepare_windows_dns_hack
  File "site-packages\dns\resolver.py", line 1073, in get_default_resolver
  File "site-packages\dns\resolver.py", line 1085, in reset_default_resolver
  File "site-packages\dns\resolver.py", line 543, in __init__
  File "site-packages\dns\resolver.py", line 720, in read_registry
  File "site-packages\dns\resolver.py", line 674, in _config_win32_fromkey
  File "site-packages\dns\resolver.py", line 639, in _config_win32_domain
  File "site-packages\dns\name.py", line 889, in from_text
  File "site-packages\dns\name.py", line 852, in from_unicode

EmptyLabel: A DNS label is empty.

Reporter

This issue was reported by 8 user(s):

Electrum Version Python Version Operating System Wallet Type Locale Stack
4.0.1 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-7-6.1.7601-SP1 standard de_DE
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-10-10.0.18362-SP0 standard de_AT
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-8.1-6.3.9600-SP0 standard ru_RU
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-10-10.0.19041-SP0 standard en_GB
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-10-10.0.19041-SP0 standard en_GB
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-7-6.1.7601-SP1 standard es_MX
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-10-10.0.18362-SP0 standard fr_FR
4.0.2 3.7.7 (tags/v3.7.7:d7c567b08f, Mar 10 2020, 09:44:33) [MSC v.1900 32 bit (Intel)] Windows-10-10.0.18362-SP0 standard fr_FR

Additional Information

no connection to any server nodes


Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with electrum/gui/qt/network_dialog.py and follow the set_proxy call into electrum/network.py and electrum/dns_hacks.py. Investigate the Windows DNS configuration path shown in the traceback and determine the conditions that produce EmptyLabel. Done means configuring a proxy on the reported Windows setups no longer crashes and the network connection behavior remains functional.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.