Considering (partial?) removal of OpenAlias support. Comment here if you use it.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
With recent refactoring of invoices/payment requests, OpenAlias support is now partially broken.
Looking up an OpenAlias (name -> addr) works, however
- signing a payment request with an openalias is broken
https://github.com/spesmilo/electrum/blob/eb39aa143b8112549a5f8156d8e3ee41034eac6a/electrum/wallet.py#L1772 - trying to pay a bip21 URI with embedded openalias name and signature is broken
https://github.com/spesmilo/electrum/blob/eb39aa143b8112549a5f8156d8e3ee41034eac6a/electrum/util.py#L854
https://github.com/spesmilo/electrum/blob/eb39aa143b8112549a5f8156d8e3ee41034eac6a/electrum/paymentrequest.py#L449
I am wondering whether this functionality is worth restoring/fixing.
We could remove the broken functionality;
or maybe we could strip OpenAlias support completely.
Do people actually use OpenAlias?
Do you use OpenAlias? What do you use it for?
If you want the project to keep supporting OpenAlias, please comment here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the OpenAlias-related paths in electrum/wallet.py:1772, electrum/util.py:854, and electrum/paymentrequest.py:449, then review the issue discussion about whether support should be fixed or removed. This issue is not ready for implementation until maintainers decide which direction to take and define the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- payments
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100