spesmilo / spesmilo/electrum

Description text around cosigner xprv might be improved

Open
#6,044 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

https://github.com/spesmilo/electrum/blob/1448bfe937eed233865acf64d38349b1e3ae2aa5/electrum/gui/qt/installwizard.py#L440-L441

The current text is:

Please enter the master public key (xpub) of your cosigner.
Enter their master private key (xprv) if you want to be able to sign for them.

I think this might be better:

Please enter the master public key (xpub/ypub/zpub) of your cosigner.
Enter their master private key (xprv/yprv/zprv) if you want to be able to sign as your cosigner's identity.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at electrum/gui/qt/installwizard.py lines 440-441, where the cosigner xpub and xprv descriptions are shown. Update the wording to mention the supported key prefixes and signing as the cosigner's identity; done when the displayed text matches the requested clarification.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.