Labelsync server produces malformed responses on error
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
Trace: https://gist.github.com/ysangkok/e4dbb2fdce9d594a706196bbdf3e170c
I believe this is the responsible line:
https://github.com/bauerj/electrum-sync-server/blob/3d8ff62cbb1ce48a02410d0e302afae1ab3c41c3/sync_master.go#L74
Seems like the fix is to return after the call to Error. See example here: https://github.com/ant0ine/go-json-rest#lookup
Reporting here because issue tracker is off on the sync server repo.
@bauerj
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at sync_master.go line 74 in the linked electrum-sync-server revision and compare its error handling with the go-json-rest lookup example. Use the provided trace to reproduce the malformed response, then verify that the server returns a valid error response after the handling path completes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100