Trezor settings dialog stuck after disabling passphrase
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
To reproduce:
- open a Trezor-based wallet
- go to Trezor settings -> Advanced settings
- Enable passphrase
- Disable passphrase
- Enable passphrase (or do anything else in the settings dialog)
expected:
- settings dialog continues to work
actual:
- "Device not connected"
The problem resolves itself after settings dialog is closed and reopened.
Internally, when disabling passphrase, devmgr.unpair_id(device_id) is called, and the subsequent action calls devmgr.client_by_id(device_id), which at that moment no longer recognizes the device ID. This is wrong - either settings should be closed, or devices rescanned or something.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Trezor settings dialog flow around devmgr.unpair_id(device_id) and the subsequent devmgr.client_by_id(device_id) call. Reproduce the enable/disable/enable passphrase sequence, then verify that further settings actions continue working without reopening the dialog.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100