spesmilo / spesmilo/electrum

Dependencies may be an attack vector

Open
#4,874 18 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build/packaging 📦 security 🔐
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

When we install electrum using pip on linux it downloads various dependencies from pypy. These are maintained by third party developers and should any one of them go rogue they could steal from us. This has recently happened to copay wallet users. Electrum does not list a specific version for most of its dependencies. Either no version number is specified or >= is used. So this sort of attack could work on Electrum too.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the dependency declarations used by the Linux pip installation and review how unpinned and >= constraints are specified. Done means the dependency versions are constrained against the described upgrade risk, with installation and compatibility checks confirming the wallet still installs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.