WalletFileException: Incomplete wallet files cannot be upgraded.

Open
#4,780 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
mobile-dev

Research direction

Start in electrum/storage.py at get_action(), then trace the wallet-loading path through electrum/daemon.py and electrum/gui/kivy/main_window.py. Investigate how the Android wallet reaches this exception and whether the reported wallet state can be reproduced. Done means the failure has a defined cause and wallet loading handles incomplete files appropriately without this crash.

Written by the indexing model from the issue text.

Description

Crash Report

This crash report was reported through the automatic crash reporting system 🤖

Traceback

  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/core/window/window_sdl2.py", line 727, in mainloop
    self._mainloop()
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/core/window/window_sdl2.py", line 460, in _mainloop
    EventLoop.idle()
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/base.py", line 340, in idle
    self.dispatch_input()
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/base.py", line 325, in dispatch_input
    post_dispatch_input(*pop(0))
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/base.py", line 291, in post_dispatch_input
    wid.dispatch('on_touch_up', me)
  File "kivy/_event.pyx", line 707, in kivy._event.EventDispatcher.dispatch
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/uix/behaviors/button.py", line 179, in on_touch_up
    self.dispatch('on_release')
  File "kivy/_event.pyx", line 703, in kivy._event.EventDispatcher.dispatch
  File "kivy/_event.pyx", line 1214, in kivy._event.EventObservers.dispatch
  File "kivy/_event.pyx", line 1098, in kivy._event.EventObservers._dispatch
  File "/data/user/0/org.electrum.electrum/files/app/crystax_python/site-packages/kivy/lang/builder.py", line 64, in custom_callback
    exec(__kvlang__.co_value, idmap)
  File "<string>", line 39, in <module>
  File "./electrum/gui/kivy/uix/dialogs/wallets.py", line 64, in open_wallet
    app.load_wallet_by_name(self.ids.wallet_selector.selection[0])
  File "./electrum/gui/kivy/main_window.py", line 521, in load_wallet_by_name
    wallet = self.daemon.load_wallet(path, None)
  File "./electrum/daemon.py", line 243, in load_wallet
    if storage.get_action():
  File "./electrum/storage.py", line 633, in get_action
    raise WalletFileException('Incomplete wallet files cannot be upgraded.')

WalletFileException: Incomplete wallet files cannot be upgraded.

Reporter

This issue was reported by 1 user(s):

Electrum Version Python Version Operating System Wallet Type Locale Stack
3.2.3 3.6.4 (default, Mar 1 2018, 10:42:21) [GCC 5.3 20151204] Android 8.0.0 on samsung greatqlte (R16NW.N950USQS5CRI4) standard ?

Additional Information

The reporting user(s) did not provide additional information.

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spesmilo/electrum

All issues in spesmilo/electrum

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.