spesmilo / spesmilo/electrum

AttributeError: 'NoneType' object has no attribute 'endswith'

Open
#4,468 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug 🐞
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Crash Report

This crash report was reported through the automatic crash reporting system 🤖

Traceback

  File "/usr/local/lib/python3.5/dist-packages/electrum/util.py", line 794, in run_with_except_hook
    run_original(*args2, **kwargs2)
  File "/usr/local/lib/python3.5/dist-packages/electrum/network.py", line 985, in run
    self.wait_on_sockets()
  File "/usr/local/lib/python3.5/dist-packages/electrum/network.py", line 967, in wait_on_sockets
    self.process_responses(interface)
  File "/usr/local/lib/python3.5/dist-packages/electrum/network.py", line 623, in process_responses
    if method.endswith('.subscribe'):

AttributeError: 'NoneType' object has no attribute 'endswith'

Reporter

This issue was reported by 3 user(s):

Electrum Version Python Version Operating System Wallet Type Locale Stack
3.1.3 Linux-4.13.0-45-generic-x86_64-with-Ubuntu-16.04-xenial imported en_US
3.1.3 Linux-4.13.0-45-generic-x86_64-with-Ubuntu-16.04-xenial imported en_US
3.2.1 Linux-4.15.0-24-generic-x86_64-with-Ubuntu-16.04-xenial imported en_US

Additional Information

The reporting user(s) did not provide additional information.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in electrum/network.py at process_responses around line 623, then trace how method is obtained before the .endswith call. Reproduce or inspect the reported crash cases and confirm that processing the affected response no longer raises AttributeError, with a regression test if the existing test suite covers this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.