Hardware wallets do not work with cosigning pool
Open
Nobody has claimed this yet.
bug 🐞
- Dominant language
- Python
- Stars
- 8.6k
- Forks
- 3.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 61
Description
Crash Report
This crash report was reported through the automatic crash reporting system 🤖
Traceback
File "/home/user/wspace/electrum/plugins/cosigner_pool/qt.py", line 205, in on_receive
xprv = wallet.keystore.get_master_private_key(password)
AttributeError: 'TrezorKeyStore' object has no attribute 'get_master_private_key'
Reporter
This issue was reported by 3 user(s):
| Electrum Version | Python Version | Operating System | Wallet Type | Locale | Stack |
|---|---|---|---|---|---|
| 3.1.2-78-g624fa476 | Linux-4.9.0-3-amd64-x86_64-with-debian-9.3 | 2of2 | en_GB | ℹ | |
| 3.1.2 | Windows-10-10.0.16299-SP0 | 2of3 | en_US | ℹ | |
| 3.1.3 | Windows-10-10.0.14393-SP0 | 2of3 | en_US | ℹ |
Additional Information
The reporting user(s) did not provide additional information.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at plugins/cosigner_pool/qt.py, especially on_receive around line 205, where the traceback shows the failure. Compare that call with the TrezorKeyStore implementation and reproduce it using a 2of2 or 2of3 hardware-wallet setup. Done means the cosigning pool no longer raises the reported AttributeError for these wallets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100