spesmilo / spesmilo/electrum

Make it configurable the number of confirmations required to make Tx confirmed

Open
#3,779 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement ✨
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

Currently, electrum treats a Tx to be confirmed if it is included in any Block. (Has any height).

On actual operation, one may want to treat Tx to be confirmed only after certain amount (e.g. 6) of confirmations be done. In other words, one wants to treat a Tx to be confirmed only if that Tx height is certain amount smaller than the current block height.

So question:

  • Is making it configurable the number of confirmations needed for Tx to be confirmed, is it a good idea or not?
  • If it is good, could this be added as a feature request (if there's such category that is...?)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Electrum's transaction-confirmation logic and the comparison between transaction height and current block height. Determine how a configurable confirmation threshold should be exposed and applied, then define tests showing that transactions become confirmed only after the configured number of confirmations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.