spesmilo / spesmilo/electrum

Ledger does not confirm fees for tx with one output

Open
#3,541 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug 🐞 hw-ledger
Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Description

On git master 3851e78454f559ec4368a4b04dd61c2b9a1f9dc1.

Using a Ledger Nano S with btchip-python 0.1.24 on debian 9.
On Ledger, using Bitcoin testnet (developer) 1.1.10

When signing a transaction with only a single output (i.e. no change either), the device does not prompt to confirm the fees.

Tested spending from both a p2pkh and also from a p2wpkh-p2sh wallet, sending to different types of outputs too.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified in the report. Reproduce on a Ledger Nano S with the listed Bitcoin testnet setup, using transactions with one output and no change from both p2pkh and p2wpkh-p2sh wallets; done means the device prompts to confirm fees in these cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.