No warning if wallet is not protected with password upon creation

Open
#2,143 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
desktop, security

Research direction

Start by tracing the wallet creation password-setting screen in the Windows standalone client, focusing on empty-password handling and the distinction between watch-only and regular wallets. Done means regular wallets cannot be created unprotected without an explicit risk acknowledgement, while watch-only behavior remains appropriate.

Written by the indexing model from the issue text.

Description

enhancement ✨ security 🔐

2.7.18, Windows standalone version

I was playing around with wallet creation and was surprised that leaving the password boxes empty, I could pass the password-setting screen without any warnings.

Storing seeds and xprv's unencrypted is not a good idea and could do much harm to the unwary novice user. How about making this opt-out? Like, when it's not a watch-only wallet, letting the user though only after ticking a box in a pop-up message that "I've understood the risks" and pressing "OK, proceed unprotected".

Dominant language
Python
Stars
8.6k
Forks
3.5k
Avg merge
2d 8h
Merged PRs (30d)
61

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spesmilo/electrum

All issues in spesmilo/electrum

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.