Migrate to RegExp lookbehind once possible
Open
Nobody has claimed this yet.
refactoring
- Dominant language
- JavaScript
- Stars
- 806
- Forks
- 434
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 32
Description
The patch just landed in Firefox 🎉🥳 https://bugzilla.mozilla.org/show_bug.cgi?id=1634135
We should still wait for Safari, though.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the regular expressions in src/core/inlines.js around lines 62-70 and src/core/inline-idl-parser.js around lines 15-17. First verify Safari support for RegExp lookbehind, then update the two expressions when support is available and run the relevant project tests to confirm parsing behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100