Remove direct imports for texts
Open
Nobody has claimed this yet.
refactoring
- Dominant language
- JavaScript
- Stars
- 806
- Forks
- 434
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 32
Description
(From #1671)
We currently depends on requirejs/text by importing CSS/JS files by e.g. import css from "deps/text!core/css/bp.css";, instead we should do:
hyperHTML`<link rel="stylesheet" href="${new URL("../core/css.bp.css", import.meta.url)}" />`
The files then should be served separately, but ultimately we should do the same for ES modules (#1640).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issue #1671 and the current uses of deps/text!core/css/bp.css; the issue does not name specific files or tests. Determine how CSS/JS files are served separately and how this relates to the planned ES module work in #1640; done means removing the direct requirejs/text imports without breaking those resources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100