spec-kitty / spec-kitty/spec-kitty

cli/commands/doctor.py is still a 1,456-LOC god-module — #1623 closed but the split did not reduce it

Open
#3,887 0 comments 0 reactions 1 assignee Claimed by @stijn-dejongh View on GitHub
priority:P3 tech-debt
Dominant language
Python
Stars
1.6k
Forks
165
Avg merge
14h 52m
Merged PRs (30d)
303

Description

**Post-convergence epic-verification refile (tracker-vs-reality drift).** Surfaced by the 2026-09-06 read-only epic-verification squad against the converged `main` (`e721763759`). Parent: #1932 (Codebase cleanup & DevEx).

## Verified current state
- `src/specify_cli/cli/commands/doctor.py` = **1,456 LOC** on `main`.
- #1623 (`[DIRECTIVE_013] doctor.py god-module: extract doctrine health-render helpers`) is CLOSED — but the module was not meaningfully reduced.

## Why this matters more now
**Sonar was removed from CI** in the convergence (the 4118-line `ci-quality.yml` holding the `sonarcloud` job was deleted in `e8cc2f444f`, 2026-08-27; the restored 179-line `ci-quality.yml` omits it). With Sonar gone and `ruff C901` reporting clean because the worst functions carry blanket `# noqa`, **nothing in CI catches this complexity** any more (audit reports 05 + 10, "whack-a-noqa").

## Related un-ticketed successors (context — crime-scene report 10)
God-modules that now outrank the deleted `cli/commands/sync.py` (−3,913 LOC, #2971) and are mostly un-ticketed: `cli/commands/agent/tasks_move_task.py` (3,344 LOC), `orchestrator_api/commands.py` (3,799 LOC), `cli/commands/agent/mission_finalize.py` (3,083 LOC, 10× `# noqa`). `runtime/next/runtime_bridge.py` (3,141) is already ticketed (#2560/#2561/#2633/#3789).

## Sibling DIRECTIVE_013 items to re-verify (closed in the same batch — flagged, NOT asserted)
- #1622 — `specify_cli.coordination.status_service` dead-symbol debt: module still present (403 LOC); needs a dead-symbol scan to confirm whether the closure was real.
- #1624 — `merge.py` `_tag_source` provenance typing: `merge.py` was decomposed (700 LOC) into a package; verify the sidecar typing actually landed in `merge/executor.py`.

## Provenance
`work/post-convergence/10-crimescene-hotspots-paula.md`, `.../05-ci-pipeline-sonar-audit-ivan.md`, `.../epic-verification/00-CONSOLIDATED.md` §B. Read-only proposal; no code changed by the verification.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.