Official GPL-1.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense()
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 71
- Forks
- 44
- Avg merge
- 12h 54m
- Merged PRs (30d)
- 7
Description
When org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().isDifferenceFound() is run on the official GPL-1.0 license text, it (incorrectly) returns true (i.e. the standard license was not matched). When I run org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().getDifferenceMessage() on it, I get:
Additional text found after the end of the expected license text starting at line #192 column #21 "end"
However the GPL-1.0 SPDX template does appear to (correctly) contain the text END OF TERMS AND CONDITIONS at this point (albeit in an <optional> block).
This was reproduced with Spdx-Java-Library v1.11 and SPDX license list v3.23.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the mismatch through LicenseCompareHelper.isTextStandardLicense() using the official GPL-1.0 text, then compare the result with the GPL-1.0 SPDX template. Trace how optional text and the END OF TERMS AND CONDITIONS marker are handled; done means the standard license is recognized without the reported extra-text difference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100