`dace.data` Refactoring Incomplete
- Dominant language
- Python
- Stars
- 593
- Forks
- 163
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 60
Description
The recent refactoring of [`dace.data`](https://github.com/spcl/dace/pull/2245) generated some inconsistencies.
- While `find_new_name()` was moved into `dace.utils` almost all parts of the code still refers to the `dace.data.find_new_name()` alias, which is provided for backwards compatibility.
- The `Data` class provides the `strides_from_layout` method which allows to compute strides based on a shape, which is kind of okay since it does not mutate any values and only reads the shape, despite the fact that `Data` does not have a concept of strides (it does not have a `strides` property only the `Array` has something like that). However, it also has the `set_strides_from_layout` function which creates a `strides` attribute on the object. However, with the exception of the `Array` this property is not serialized. Therefore, this method does not belong to `Data` and should be moved to `Array` the only logical place.
Contributor guide
Assessment
This issue has not been assessed yet.