spcl / spcl/dace

Structs Not Passed To SDFG Init Function on Main (But OK on F2DaCe)

Open
#2,060 0 comments 0 reactions 2 assignees Claimed by @acalotoiu View on GitHub
Dominant language
Python
Stars
593
Forks
163
Avg merge
2d 23h
Merged PRs (30d)
60

Description

I load and compile using this py-script:
```
import dace

sdfg = dace.SDFG.from_file("gpu_velocity_no_nproma_if_prop_lvn_only_0_istep_1_stage1.sdfgz")

sdfg.compile()
```

This results with successful compilation on f2dace branches (latest commit June 18).

`f2dace/staging` hash: `dfe20ab947cb826def0c886194395edfec81352f`
`f2dace/dev` hash: `24837bc0d2b9f42fb87cea32b15c28b67f9ed311`

But does not work on `main`, hash: `7cb70d67ab2eaac44d3195ad328fc1fb96b526b0` (latest commit June 18)

Errors are:
```
/home/primrose/Work/IconGrounds/icon-artifacts/velocity/codegen/.dacecache/velocity_no_nproma_if_prop_lvn_only_0_istep_1/src/cpu/velocity_no_nproma_if_prop_lvn_only_0_istep_1.cpp:2743:41: error: ‘p_prog’ was not declared in this scope
2743 | __f2dace_SOA_w_d_0_s_285_p_prog_7 = p_prog->__f2dace_SOA_w_d_0_s_285;
| ^~~~~~
/home/primrose/Work/IconGrounds/icon-artifacts/velocity/codegen/.dacecache/velocity_no_nproma_if_prop_lvn_only_0_istep_1/src/cpu/velocity_no_nproma_if_prop_lvn_only_0_istep_1.cpp:2753:54: error: ‘p_metrics’ was not declared in this scope; did you mean ‘t_nh_metrics’?
2753 | __f2dace_SOA_ddxn_z_full_d_0_s_308_p_metrics_8 = p_metrics->__f2dace_SOA_ddxn_z_full_d_0_s_308;
| ^~~~~~~~~
| t_nh_metrics
/home/primrose/Work/IconGrounds/icon-artifacts/velocity/codegen/.dacecache/velocity_no_nproma_if_prop_lvn_only_0_istep_1/src/cpu/velocity_no_nproma_if_prop_lvn_only_0_istep_1.cpp:2809:42: error: ‘p_diag’ was not declared in this scope
2809 | __f2dace_SOA_vt_d_0_s_291_p_diag_9 = p_diag->__f2dace_SOA_vt_d_0_s_291;
```

As these structs are not passed to the init function properly.

You can use this SDFG attached: (`.txt` is a fake suffix to make Github issues accept uploading it, remove it before reproducing)

[gpu_velocity_no_nproma_if_prop_lvn_only_0_istep_1_stage1.sdfgz.txt](https://github.com/user-attachments/files/20802871/gpu_velocity_no_nproma_if_prop_lvn_only_0_istep_1_stage1.sdfgz.txt)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.