spcl / spcl/dace

[f2dace] Cutouts working on main but not on f2dace

Open
#2,000 0 comments 0 reactions 0 assignees View on GitHub
fortran
Dominant language
Python
Stars
593
Forks
163
Avg merge
2d 23h
Merged PRs (30d)
60

Description

Cutouts work fine on `main` branch (hash: `d8b0347725204341c656c9be72d5221b736aa4af`)
Not on `f2dace/dev` (tested commit hash: `8abc38060233d56a52ffa8e79c1ddeb8022f0f1d`)

Error:
```
Traceback (most recent call last):
File "/home/primrose/Work/LayoutArtifacts/SemiStructuredStencil/cutout_repr.py", line 20, in
kernel_sdfg = copy_sub_scope(state, node)
File "/home/primrose/Work/LayoutArtifacts/SemiStructuredStencil/cutout_repr.py", line 13, in copy_sub_scope
cut_sdfg = SDFGCutout.singlestate_cutout(state, *nn)
File "/home/primrose/Work/dace/dace/sdfg/analysis/cutout.py", line 331, in singlestate_cutout
cutout.output_config = _cutout_determine_output_configuration(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
cutout, out_reach, in_translation, out_translation
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/home/primrose/Work/dace/dace/sdfg/analysis/cutout.py", line 1062, in _cutout_determine_output_configuration
for edge in original_state.parent.out_edges(original_state):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
File "/home/primrose/Work/dace/dace/sdfg/graph.py", line 658, in out_edges
return list(self._nodes[node][1].values())
~~~~~~~~~~~^^^^^^
KeyError: SDFGState (MapState)
```

Looks like one of the PR's we did with Phil did not make it to the f2dace as I remember similar errors and fixing it in. This one exactly: https://github.com/spcl/dace/pull/1933

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.