sparklemotion / sparklemotion/http-cookie
Support for unixsockets (empty domains)
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 135
- Forks
- 55
- Avg merge
- 1m
- Merged PRs (30d)
- 4
Description
There are tests which check for a valid domain, e.g.: https://github.com/sparklemotion/http-cookie/blob/master/lib/http/cookie.rb#L572
Thats good, but it is a blocker if http is used over a unixsocket.
Is there a possiblity to work around this test on a proper way?
For quick testing I just replaced the "raise" in line 572 with "true", which "fixes" the issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/http/cookie.rb around line 572 and read the existing domain-validation tests referenced by the issue. Trace how Unix socket use is represented at this boundary, then define coverage for the socket case while preserving valid-domain checks. Done means the test suite covers Unix socket cookies without weakening ordinary domain validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100