spacebarchat / spacebarchat/server

[Tracking] C#/Gateway Offload: resolve TODOs

Open
#1,612 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.NET Good first issue Priority:low
Dominant language
TypeScript
Stars
2.2k
Forks
323
Avg merge
14h 48m
Merged PRs (30d)
4

Description

Generated at commit 57827bc9:

  • extra/admin-api/Spacebar.GatewayOffload/Controllers/ChannelStatusController.cs:52: status = statusOptions[new Random().Next(statusOptions.Length)], // TODO: We don't currently store channel statuses, so make some stuff up
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/ChannelStatusController.cs:53: voiceStartTime = DateTime.Now.Subtract(TimeSpan.FromMinutes(new Random().Next(1, 120))), // TODO: We also don't store voice start times, so make some stuff up
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/Op8Controller.cs:45: // TODO: figure out how to abstract this to a function without EFCore complaining about not being translatable...
  • ``extra/admin-api/Spacebar.GatewayOffload/Controllers/Op8Controller.cs:61: // see TODO on IsOnline - somehow need to replicate `IsOnline(s)```
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/Op14Controller.cs:17: // TODO: actually return something?
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/Op14Controller.cs:49: return null; // TODO
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/IdentifyController.cs:45: // TODO: type? also, implement this in gateway lol
  • extra/admin-api/Spacebar.GatewayOffload/Controllers/Op12Controller.cs:45: // TODO: figure out how to abstract this to a function without EFCore complaining about not being translatable...
  • ``extra/admin-api/Spacebar.GatewayOffload/Controllers/Op12Controller.cs:61: // see TODO on IsOnline - somehow need to replicate `IsOnline(s)```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the controllers listed under extra/admin-api/Spacebar.GatewayOffload, using the generated commit 57827bc9 to review each TODO in context. Trace the existing gateway and EF Core behavior around ChannelStatus, Op8, Op12, Op14, and Identify, then resolve every checked item and verify that the affected admin API responses behave as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.