spacebarchat / spacebarchat/server

What on earth is session_id: "all"???

Open
#1,092 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs more information
Dominant language
TypeScript
Stars
2.2k
Forks
323
Avg merge
14h 48m
Merged PRs (30d)
4

Description

https://github.com/spacebarchat/server/blob/ccc774168a0612c6892b7862141e58b28b029aec/src/gateway/opcodes/Identify.ts#L338

image

It's only sent if you're logged in with desktop clients, and READY will send 2 sessions for the 1 desktop session.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/gateway/opcodes/Identify.ts around line 338 and inspect how desktop clients send session_id: "all" and how READY constructs the returned sessions. Reproduce the desktop login flow and compare the session list with the single desktop session; the intended handling of the extra session still needs to be established.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.