space-wizards / space-wizards/RobustToolbox
Overriding the sawmill log level within code will ignore the log.level cvar level
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 693
- Forks
- 746
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 22
Description
Example in MapLoaderSystem you can see that it manually sets the Log level to Info
https://github.com/space-wizards/RobustToolbox/blob/56c30edf04d8efccd21d17b4be033ef316c99b4e/Robust.Server/GameObjects/EntitySystems/MapLoaderSystem.cs#L64
Now set your log.level cvar in your config to Error. Your config is ignored and Info is printed into console
Commenting the above line fixes this, but if I understood correctly this is done to prevent spam (?)
The real fix is to ensure log.level is always respected first.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Robust.Server/GameObjects/EntitySystems/MapLoaderSystem.cs around line 64 and trace how the Info log level is set relative to the log.level cvar. Reproduce with log.level set to Error, then verify that the configured level remains respected while the MapLoaderSystem logging behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100