space-wizards / space-wizards/RobustToolbox
edgeSpritePriority corners layering error
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 693
- Forks
- 746
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 22
Description
https://github.com/space-wizards/space-station-14/issues/29276
The current logic has a bunch of bugs with rendering.
- Corner edges of a tile are compared only with the corner neighbor, which means that several layers can be drawn on one corner at once, overlapping each other
- Given the order in which edges are rendered (left to right from top to bottom of all tiles), side edges can overlap each other, also breaking priorities and visuals
Considering that the game uses only 2 tiles with edge priorities (grass and snow), these tiles are extremely rare in the Continental biome up close, and that the corners are extremely small, no one just didn't see this bug.
Unfortunately, trying to experiment with sprite edge sizes, strongly demonstrated this bug.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Space Station 14 issue and the attached rendering examples to understand the reported corner and side-edge overlaps. Then locate the edge-priority rendering entry point and verify that corner and side edges no longer overlap while their priorities and visuals are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100