space-wizards / space-wizards/RobustToolbox
Calling StopPlaying on audio twice shouldn't crash
Open
Nobody has claimed this yet.
Priority: 1-Urgent
T: Bugfix
- Dominant language
- C#
- Stars
- 693
- Forks
- 746
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 22
Description
There's no way to check if a source is disposed from content so if you try to stop a stream twice it crashes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the StopPlaying entry point and the audio source disposal path. Reproduce stopping the same stream twice, then inspect how disposed sources are handled. Done means repeated StopPlaying calls no longer crash, with a regression test if the existing audio tests provide a suitable location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100