space-wizards / space-wizards/RobustToolbox

Wrap LocalRotation around 2 Pi

Open
#2,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

D2: Medium Priority: 3-Not Required T: New Feature
Dominant language
C#
Stars
693
Forks
746
Avg merge
3d 9h
Merged PRs (30d)
22

Description

Currently it's possible for something to rotate indefinitely and cause precision issues. We can probably just do a modulus when setting LocalRotation and she'll be right. It also means you won't get any funky values when mapping as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the LocalRotation setter or entry point and trace how rotation values are mapped. Confirm the expected wrapping behavior around 2 Pi, then verify that indefinitely rotating values remain bounded and mapping no longer produces unexpected values.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.