sourcegraph / sourcegraph/scip-ruby

scip-ruby-arm64-linux builds

Open
#228 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement graph/scip-ruby team/graph
Dominant language
Ruby
Stars
22
Forks
4
Avg merge
4h 58m
Merged PRs (30d)
4

Description

Problem

Stripe makes contributions to Sorbet and uses the HEAD version of Sorbet internally. Our scip-ruby CI job is set up to pass the exact same flags that we pass to sorbet, into scip-ruby.

When the Sorbet team changes CLI flags and bumps the version of Sorbet used internally, all tests pass, even though scip-ruby doesn't support the extra flags. That's because we only run scip-ruby CI job every 30m, instead on every push.

Then, later I find out that the scip-ruby CI job is failing because of ~"unknown CLI arguments".

So I've been (after the fact) patching the sorbet config in our scip-ruby CI job using something like this:

# Mod the Sorbet config to replace `--uniquely-defined-behavior` with `--stripe-mode`
sed -i 's/--uniquely-defined-behavior/--stripe-mode/' sorbet/config
# Delete the `--extra-package-files-directory-prefix-slash-deprecated` line
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/config
sed -i '/--extra-package-files-directory-prefix-slash-deprecated/d' sorbet/extra-package-directories.txt
# Delete the line starting with `--packager-layers`
sed -i '/--packager-layers/d' sorbet/config

This is kind of a cat-and-mouse game, so I'd like to make it so that when the Sorbet team bumps the Sorbet version, we run a test specifically checking that the flags are valid with scip-ruby too.

Our CI environment runs arm64 and x86_64 randomly but for Linux we only have x86_64 builds.

So I can't write the test until we have Linux arm64 builds :(

Suggested solution

https://github.com/sourcegraph/scip-ruby/releases/tag/scip-ruby-v0.4.3 currently scip-ruby-x86_64-linux and I would love a scip-ruby-arm64-linux too please

Compared to other tools

No response

OSS Examples

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the scip-ruby CI job and the existing scip-ruby-x86_64-linux release artifact linked in the issue. Add the corresponding Linux arm64 build and release output; done means a scip-ruby-arm64-linux artifact is available for the referenced release workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.