sourcegraph / sourcegraph/deploy-sourcegraph-helm
Executor Helm Chart - kubernetesJob.node.tolerations doesn't render as expected
Nobody has claimed this yet.
- Dominant language
- Go Template
- Stars
- 18
- Forks
- 24
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 13
Description
When setting the value for executor.kubernetesJob.node.tolerations it does not render in the configmap in the way that the executor pod is able to consume it.
I'm finding that if you set the following as the chart suggests:
tolerations: [{"key": "foo", "operator": "Equal", "value": "bar", "effect": "NoSchedule"}]
It will render as EXECUTOR_KUBERNETES_NODE_TOLERATIONS: map[effect:NoSchedule key:foo operator:Equal value:bar]
Causing your executor pod to throw invalid EXECUTOR_KUBERNETES_NODE_TOLERATIONS, failed to parse: invalid character 'm' looking for beginning of value into the logs and does not execute jobs.
If you do a manual edit of the configmap back to the original Json specified in the chart, then the jobs executor and respect the tolerations.
I think the chart is incorrectly trying to render the json to yaml, when it should remain as json.
https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml#L26
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect charts/sourcegraph-executor/k8s/templates/executor.ConfigMap.yaml at line 26 and the tolerations value in charts/sourcegraph-executor/k8s/values.yaml around lines 116-117. Render the chart with the documented tolerations value and compare the configmap output with the JSON the executor expects. Done means the rendered EXECUTOR_KUBERNETES_NODE_TOLERATIONS value remains valid JSON and the executor can parse it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100