sourcefuse / sourcefuse/loopback4-microservice-catalog
/notification-users get api is not working for userTenantId (issue of @sourceloop/notification-service)
Open
@harshitmitSF is already working on this.
Since May 17, 2021.
bug
- Dominant language
- TypeScript
- Stars
- 297
- Forks
- 78
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
Is your feature request related to a problem? Please describe.
/notification-users get api is not working for userTenantId because we are using user tenant id for our socket connection which is "to" parameter in request and currently it is comparing userId column value with token userId
Describe the solution you'd like
We can check userTenantId for userId column or we should introduce a provider for checking column value
Describe alternatives you've considered
currently using a new controller for handling /notification-users get api
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.