sourceallies / sourceallies/interviews

Investigate overall effectiveness of global.json file for locking SDK version in pairing sessions

Open
#370 0 comments 0 reactions 1 assignee View on GitHub

@rjrjensen is already working on this.

Since Nov 13, 2025.

Dominant language
TypeScript
Stars
12
Forks
20
Avg merge
2h 46m
Merged PRs (30d)
1

Description

Erik brought up re-adding the global.json just as a precaution and I want to make sure that there won't be an issue with leaving it out. I always aim for fewest files, lines per file, etc., but if global.json saves us a headache later, I'll cave and add it back.

Message

Overall LGTM.

Minor nit on line endings, typically there's a \n at the end of every file. This symbol means the final newline is missing

Image

Also curious about your thoughts on the removal of the global.json file? Typically its better to pin dependencies.

Originally posted by @UnstoppableMango in https://github.com/sourceallies/interviews/pull/350#pullrequestreview-3316298617

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.