sonic-net / sonic-net/sonic-platform-vpp

Improve debuggablity

Open
#116 4 comments 1 reaction 1 assignee View on GitHub

@alkama-hasan is already working on this.

Since Oct 21, 2024.

Dominant language
C
Stars
75
Forks
72
Avg merge
5d 15h
Merged PRs (30d)
4

Description

Debuggability at SONIC-VPP SAI layer is poor. If we turn on syncd debug log, it becomes too chatty because that's the level logged by SWSS_LOG_ENTER. And the latter doesn't print arguments. Also, major operations are not logged either.

Proposals

  1. Use SWSS_LOG_INFO. It is not turned on by default and it is above debug level so won't be overwhelmed by debug messages.
  2. All VPP API calls should be logged as INFO with parameters.
  3. Create/set/remove requests from syncd should be logged as INFO with arguments
  4. Other important logs can be added as needed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.