somewhatabstract / somewhatabstract/checksync

When auto-fixing, added line-ending should match line-ending of file being edited

Open
#665 1 comment 0 reactions 1 assignee View on GitHub

@somewhatabstract is already working on this.

Since Jun 15, 2021.

bug enhancement
Dominant language
TypeScript
Stars
20
Forks
3
Avg merge
25m
Merged PRs (30d)
21

Description

When auto-fixing, we use the \n character as a line-ending, but on Windows, the line-ending is more likely to be \r\n. We could use os.EOL but this may not match the file that we are fixing, so we should detect the line ending during parsing and then use that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.