solidusio / solidusio/solidus_subscriptions
Subscriptions currently failing on sqlite after latest changes to promotion system
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 49
- Forks
- 53
- Avg merge
- 4h 54m
- Merged PRs (30d)
- 1
Description
Hey @mamhoff
@shahmayur001 fixed the tests and made the gem work with 4.x on starter frontend, but it seems there are some issues with the new promotion system on 4.4.2 (4.4.1 did install and function correctly).
We are experiencing some issues with:
- installing on solidus with the new promotion gem
- tests are failing again after they worked (more or less flawlessly) on PR
Can you help us to wrap this up and make it all work so that @jarednorman and @kennyadsl can wrap it up into a release?
@shahmayur001 please post the error messages.
Solidus Version:
4.4.2
To Reproduce
Install current subscription main gem over 4.4.2.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by installing the current subscription main gem over Solidus 4.4.2 and collect the missing error messages, then compare the failing tests with the changes in PR 306. Done means the gem installs with the new promotion system and the test suite passes again on SQLite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100