solidusio / solidusio/solidus_subscriptions

Subscriptions do not fail properly in starter front-end when no valid payment method present

Open
#307 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
49
Forks
53
Avg merge
4h 54m
Merged PRs (30d)
1

Description

Subscriptions require a valid payment method for recurring payments. if no valid recurring payment method is present, the subscription is not created but the order completed on starter front end with a regular item and payment pending.

Solidus Version:
Current

To Reproduce
Create a subscription with checque as payment method

Current behavior
An order is created with payment pending, but the subscription is not created

Expected behavior
The order fails in frontend

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the starter front end by reproducing the issue with a subscription using checque as the payment method. Trace the checkout and payment-pending behavior, then verify that an invalid recurring payment method causes the frontend operation to fail rather than completing the order without creating the subscription.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
frontend, payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.