solidusio / solidusio/solidus_subscriptions
Fix the PDP subscription form
Open
Nobody has claimed this yet.
stale
- Dominant language
- Ruby
- Stars
- 49
- Forks
- 53
- Avg merge
- 4h 54m
- Merged PRs (30d)
- 1
Description
The PDP subscription form is not working correctly:
- it appears also if the product is not subscribable
- the default PDP quantity input is used to set the subscribable_id (the variant id)
- the interval units fields are not filled with a default value
- the subscription quantity is handled by a redundant field
How to fix:
- show the subscription form only if the product or one of the product variant is subscribable
- use the default PDP quantity input to set the subscription quantity
- fill the interval units fields with a default value
- remove the redundant field
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the PDP subscription form entry point and trace how product subscribability, variant IDs, the default PDP quantity, interval units, and subscription quantity are handled. Done means the form appears only for subscribable products or variants, uses the default quantity for subscriptions, supplies default interval units, and has no redundant quantity field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100