solidusio / solidusio/solidus_auth_devise
solidus_auth_devise should create the columns it needs
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 56
- Forks
- 124
- Avg merge
- 4h 56m
- Merged PRs (30d)
- 1
Description
Currently the first migration creates the whole spree_users table if it doesn't exist, but while it should do that, we should allow it to create the columns it needs if the table exists but doesn't contain those columns. This would allow us to merge https://github.com/solidusio/solidus/pull/6442 (which is a rebase of https://github.com/solidusio/solidus/pull/4440) and get the Devise-specific stuff out of Solidus core.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the first solidus_auth_devise migration and inspect how it handles an existing spree_users table. Done means the migration still creates the table when absent, adds the required missing columns when it exists, and verifies both paths with the relevant migration tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- authentication, database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100