Deprecate legacy promotion system
Open
Nobody has claimed this yet.
changelog:solidus_core
changelog:solidus_legacy_promotions
- Dominant language
- Ruby
- Stars
- 5.3k
- Forks
- 1.4k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 62
Description
Desired Behavior
Anything related to the use of the legacy promotion system should show a deprecation warning this system will be removed from Solidus 5.0. This can go on the main configuration option.
Current Behavior
Unsure of status of current deprecations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the main configuration option for the legacy promotion system and reviewing existing deprecation warnings in the Solidus codebase. Trace which legacy promotion behavior uses that option, then verify that its use emits a warning stating the system will be removed in Solidus 5.0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100