solidusio / solidusio/solidus

Admin Tailwind preset overrides the host app's default theme values

Open
#6,470 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

changelog:solidus_admin
Dominant language
Ruby
Stars
5.3k
Forks
1.4k
Avg merge
1d 22h
Merged PRs (30d)
62

Description

The Solidus Admin installer mutates the host apps TW config, in order to allow changing the theme and to extend the admin with own TW based components.

The issue is that we overwrite the default theme with values from the Solidus Admin, by using presets and reusing the default TW color names and font sizes, etc. We either should prefix all our values with solidus- or just don't do that.

https://github.com/solidusio/solidus/blob/65572c86bab981e10e7e4f498774b76c8e5bce25/admin/lib/solidus_admin/install_tailwindcss.rb#L24

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with admin/lib/solidus_admin/install_tailwindcss.rb at the linked lines and read the Tailwind presets documentation. Reproduce the installer against a host Tailwind configuration containing default theme values, then verify that the host theme remains intact while Solidus Admin can still be themed and extended. Done means the chosen prefixing or preset behavior no longer overrides host defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, tailwindcss
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.