solidusio / solidusio/solidus

Commit the built Tailwind CSS file for the admin

Open
#5,655 1 comment 0 reactions 1 assignee View on GitHub

@tvdeyen is already working on this.

Since Oct 18, 2024.

changelog:solidus_admin
Dominant language
Ruby
Stars
5.3k
Forks
1.4k
Avg merge
1d 22h
Merged PRs (30d)
62

Description

          What do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even until then it makes sense to have it updated regularly (not just on gem release).

People might use solidus_admin from git source like this

# Gemfile
gem "solidus_admin", github: "solidusio/solidus", branch: "v4.3"

(in order to get bug fixes early for stable versions that have not been released yet.)

We want to make sure they get the admin css file, right?

Originally posted by @tvdeyen in https://github.com/solidusio/solidus/pull/5595#discussion_r1456396184

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.