`Spree::UnitCancel` mishandles loaded associations and order totals
Open
Nobody has claimed this yet.
changelog:solidus_core
- Dominant language
- Ruby
- Stars
- 5.3k
- Forks
- 1.4k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 62
Description
UnitCancel seems to have a few issues with no simple solutions. We had some PRs with failing specs illustrating those issues:
- #1455 Failing test: UnitCancel with loaded associations
- #1357 Cancelling Inventory updates tax_total & item total
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the failing specs and changes referenced in PRs #1455 and #1357. Reproduce those cases around UnitCancel, then use the expected behavior in those specs as the definition of done for loaded associations and order, tax, and item totals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100